Allow warnings during local development #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or where it errors if libtock-rs has warnings. This is a second attempt at PR tock#270. We can't specify RUSTFLAGS directly because doing so overrides all rustflags configurations in .cargo/config. Those rustflags configs are important because they configure relocation and set the linker script. Instead, I append the "deny warnings" config to .cargo/config in CI itself.
jrvanwhy
added
the
significant
alistair23
approved these changes
Feb 3, 2021
|
why will this make it harder to see errors locally? |
|
If someone is checking their changes locally warnings won't be errors. |
|
I think this PR is ready to merge. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keep's CI's behavior where it errors if libtock-rs has warnings.
This is a second attempt at PR #270. We can't specify
RUSTFLAGSdirectly because doing so overrides allrustflagsconfigurations in.cargo/config. Thoserustflagsconfigs are important because they configure relocation and set the linker script. Instead, I append the"deny warnings"config to.cargo/configin CI itself.I tested this by opening two PRs in my fork: one to test that this PR still builds, and one to test it fails if a warning is present.
I am not terribly happy with this solution (feels really hacky rather than kinda hacky), so any alternative implementation ideas would be appreciated!